Ensure 127.0.0.1 for the --bind-address parameter #1723
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ktsakalozos
force-pushed
the
fix-bind-address-check
branch
from
ea4ec06 to
2d999ee
Compare
afdesk
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
LGTM! @ktsakalozos thanks for the contribution!
@mozillazg wdyt?
mozillazg
approved these changes
Nov 15, 2024
|
@afdesk It seems other benchmarks may have similar issues, do we need to update the checking logic for those benchmarks as well? We can make these changes in another new PR. wdyt? |
@mozillazg I agree with you. let's create a new issue. |
|
@ktsakalozos could you update the PR with the current main branch? thanks |
ktsakalozos
force-pushed
the
fix-bind-address-check
branch
from
adccb29 to
9e3b808
Compare
|
It should be ok now @afdesk |
|
@ktsakalozos thanks again! LGTM! merged |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If
--bind-addressof kube-scheduler and kube-controller-manager is not set it defaults to 0.0.0.0 (all interfaces) [1, 2].The respective checks (1.3.7 and 1.4.2) should not accept the default bind-address value and should fail if
--bind-addressis not set.[1] https://kubernetes.io/docs/reference/command-line-tools-reference/kube-scheduler/
[2] https://kubernetes.io/docs/reference/command-line-tools-reference/kube-controller-manager/